-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix post alignment #1131
Fix post alignment #1131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
aren't they looking too big now,though? we can fix that later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Might be but images need atleast that much height. I think we can do the fixing with caption and header. |
right, there's too much whitespace above and below the image |
* moved search to navbar and displayed in a modal * positioned story icons * story ui * reduced css * style: format * refactored profile and associated css * minor fix * edit icon style * save btn * style: format * refactor: removed unused code * merge and added frnd req btn * fix: sidebar z index --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> bug-fix-1114 (narayan954#1122) Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1130) Format code with prettier This commit fixes the style issues introduced in 4fb0286 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/0b1c3e2a-d282-4658-9354-2a54dfff5db5/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> fixed menu icon hover (narayan954#1127) * fixed menu icon hover * fix: random --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> Add message on zero likes (narayan954#1129) Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1134) Format code with prettier This commit fixes the style issues introduced in 7111899 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/f6f68b3c-9dcf-4691-bc3e-3efd65b984cc/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Fix post alignment (narayan954#1131) * Fix post alignment * refactor: imageslider --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> Search bar (narayan954#1124) * Altered search bar style * style: format * fix: sidebar z axis on big screens * Resolve css bugs of search bar --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1135) Format code with prettier This commit fixes the style issues introduced in 505257a according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/8bbfde96-60b5-4671-9483-edfb9b83472e/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Moved saved posts from sidebar to profile (narayan954#1126) * Moved saved posts from sidebar to profile * style: format --------- Co-authored-by: narayan soni <narayansoni854@gmail.com> Edit Profile UI (narayan954#1128) * moved search to navbar and displayed in a modal * positioned story icons * story ui * reduced css * style: format * ui change * responsive * edit icon * style: format * responsive * minor fix * removed commentted code * fix * fix: styles --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> Add bg zoom in effect on scroll (narayan954#1133) * animation zoom out effect on profile background image * style: formatting * Add zoom in effect to profile bg animation * fix: stuffs --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> fixed alignment added delete message profile and background image cleanup from cloud (narayan954#1108) * profile and background image cleanup from cloud * Fix imgCleanup * style: format --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1158) Format code with prettier This commit fixes the style issues introduced in 512022e according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/c962e8d2-6bb3-457b-98df-ad1b7da63e84/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> card margin and search bar (narayan954#1125) * card margin and search bar * style: format * fix: class->classname * changes resolve --------- Co-authored-by: narayan soni <narayansoni854@gmail.com> Fix post text alignment (narayan954#1144) Co-authored-by: Narayan soni <narayansoni854@gmail.com> Trim profile dialog box bio (narayan954#1145) Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1162) Format code with prettier This commit fixes the style issues introduced in 4c534ec according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/80eb5592-ee8f-4087-b765-030caa0764f0/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> fix: bio bug Add shimmer on like dialog box (narayan954#1148) * Add shimmer on like dialog box * fix: random stuffs --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> Add new loader for dummygram (narayan954#1150) * Add new loader for dummygram * fix: classname,props,comment, formatting --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1164) Format code with prettier This commit fixes the style issues introduced in d2ad8d7 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/158e9102-77d4-4044-9569-d5f99fd3c69b/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
author Palak <Palakgoyal0304@gmail.com> 1690999258 +0530 committer Anamika Yadav <aanyayadav419@gmail.com> 1691262867 +0530 parent 5e5e711 author Palak <Palakgoyal0304@gmail.com> 1690999258 +0530 committer Anamika Yadav <aanyayadav419@gmail.com> 1691262861 +0530 parent 5e5e711 author Palak <Palakgoyal0304@gmail.com> 1690999258 +0530 committer Anamika Yadav <aanyayadav419@gmail.com> 1691262850 +0530 Suggestion (narayan954#1080) * Add user suggestion on home page * Solve bug of suggestion on width greater than 1300 * style: format --------- Co-authored-by: narayan soni <narayansoni854@gmail.com> Fix logo on share modal (narayan954#1090) Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1105) Format code with prettier This commit fixes the style issues introduced in 5061dd0 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/6638c711-49d1-4661-adbe-d7bbdd7f897b/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> added delete message style: format style: format code with prettier (narayan954#1115) Format code with prettier This commit fixes the style issues introduced in b0f6683 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/8d0eabe6-4bf5-4d4b-9192-b30877eb3e4a/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Delete option (narayan954#1107) * Add delete post on post page * refactor: remove script.js * style: format * fix: filename error --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1116) Format code with prettier This commit fixes the style issues introduced in c3e8a08 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/b41c7eb4-13ae-455d-95df-b9285ecec6b1/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Add gssoc in program list (narayan954#1109) Co-authored-by: Narayan soni <narayansoni854@gmail.com> Change theme toggle button to switch (narayan954#1110) * Change theme toggle button to switch * style: format --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1118) Format code with prettier This commit fixes the style issues introduced in 18f5aa8 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/b6a46448-81b9-4d1f-8604-e3466f56a2f6/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> style: format code with prettier (narayan954#1121) Format code with prettier This commit fixes the style issues introduced in 9ccadc3 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/1b29221d-534d-4394-b66f-5eef978ce1e1/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Refactored profile (narayan954#1119) * moved search to navbar and displayed in a modal * positioned story icons * story ui * reduced css * style: format * refactored profile and associated css * minor fix * edit icon style * save btn * style: format * refactor: removed unused code * merge and added frnd req btn * fix: sidebar z index --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> bug-fix-1114 (narayan954#1122) Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1130) Format code with prettier This commit fixes the style issues introduced in 4fb0286 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/0b1c3e2a-d282-4658-9354-2a54dfff5db5/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> fixed menu icon hover (narayan954#1127) * fixed menu icon hover * fix: random --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> Add message on zero likes (narayan954#1129) Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1134) Format code with prettier This commit fixes the style issues introduced in 7111899 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/f6f68b3c-9dcf-4691-bc3e-3efd65b984cc/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Fix post alignment (narayan954#1131) * Fix post alignment * refactor: imageslider --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> Search bar (narayan954#1124) * Altered search bar style * style: format * fix: sidebar z axis on big screens * Resolve css bugs of search bar --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1135) Format code with prettier This commit fixes the style issues introduced in 505257a according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/8bbfde96-60b5-4671-9483-edfb9b83472e/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Moved saved posts from sidebar to profile (narayan954#1126) * Moved saved posts from sidebar to profile * style: format --------- Co-authored-by: narayan soni <narayansoni854@gmail.com> Edit Profile UI (narayan954#1128) * moved search to navbar and displayed in a modal * positioned story icons * story ui * reduced css * style: format * ui change * responsive * edit icon * style: format * responsive * minor fix * removed commentted code * fix * fix: styles --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> Add bg zoom in effect on scroll (narayan954#1133) * animation zoom out effect on profile background image * style: formatting * Add zoom in effect to profile bg animation * fix: stuffs --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> fixed alignment added delete message profile and background image cleanup from cloud (narayan954#1108) * profile and background image cleanup from cloud * Fix imgCleanup * style: format --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1158) Format code with prettier This commit fixes the style issues introduced in 512022e according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/c962e8d2-6bb3-457b-98df-ad1b7da63e84/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> card margin and search bar (narayan954#1125) * card margin and search bar * style: format * fix: class->classname * changes resolve --------- Co-authored-by: narayan soni <narayansoni854@gmail.com> Fix post text alignment (narayan954#1144) Co-authored-by: Narayan soni <narayansoni854@gmail.com> Trim profile dialog box bio (narayan954#1145) Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1162) Format code with prettier This commit fixes the style issues introduced in 4c534ec according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/80eb5592-ee8f-4087-b765-030caa0764f0/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> fix: bio bug Add shimmer on like dialog box (narayan954#1148) * Add shimmer on like dialog box * fix: random stuffs --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> Add new loader for dummygram (narayan954#1150) * Add new loader for dummygram * fix: classname,props,comment, formatting --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com> style: format code with prettier (narayan954#1164) Format code with prettier This commit fixes the style issues introduced in d2ad8d7 according to the output from Prettier. Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/158e9102-77d4-4044-9569-d5f99fd3c69b/ Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
This PR closes #1084
![Screenshot 2023-08-04 194617](https://private-user-images.githubusercontent.com/116902573/258445896-9e9c1ac9-8269-44da-9e12-039ecc74ee88.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwMjk0NTksIm5iZiI6MTcyNjAyOTE1OSwicGF0aCI6Ii8xMTY5MDI1NzMvMjU4NDQ1ODk2LTllOWMxYWM5LTgyNjktNDRkYS05ZTEyLTAzOWVjYzc0ZWU4OC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkxMVQwNDMyMzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zMzdmMWNjNTk5OTJhMWRjNTZmNWU0OWVhM2EzMWQwZDU0MzM2MjZiMjhmM2Q4NTdiNGMzN2Y3ZDMxYzQ0OWIwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.79JZ2KLEzAh1Iy6sAHDjj0iVvhD_EH6cDDu289KzMCk)
By fixing the height of image they are aligned properly.